Upgrade to be used with RN >= 0.47

BondGoat / react-native-native-video-player

React native video player, used for Android, iOS. It will lauch a Native Video, not an Embeded Component

GNU General Public License v3.0

50 stars 44 forks source link

Upgrade to be used with RN >= 0.47 #14

Closed matiasfha closed 6 years ago

matiasfha commented 6 years ago

Upgrade to be user with RN >= 0.47 (Including this https://github.com/BondGoat/react-native-native-video-player/pull/10 )
Fixed the Header Search Path issue in ios (reference to a non-existent folder)

matiasfha commented 6 years ago

@BondGoat Can you take a look? :D

johncblandii commented 6 years ago

Can we get this in, @BondGoat?

Error:(23, 5) error: method does not override or implement a method from a supertype

balsloev commented 6 years ago

I will paste the error message here for Google to index it:

node_modules/react-native-native-video-player/android/src/main/java/com/wog/videoplayer/VideoPlayerPackage.java:23: error: method does not override or implement a method from a supertype @Override ^

This will fix the problem: https://github.com/BondGoat/react-native-native-video-player/pull/14/commits/d1154a9787276df1211eda3e85617168c652a40e