search

BondGoat / react-native-native-video-player

React native video player, used for Android, iOS. It will lauch a Native Video, not an Embeded Component
GNU General Public License v3.0
50 stars 44 forks source link

Get the rootViewController without casting to AppDelegate #30

Closed ericmgoeken closed 5 years ago

ericmgoeken commented 5 years ago

The AppDelegate.h is only used so that we can grab the rootViewController, but Alexander Voityuk @a-voityuk has shown how to do this in

https://github.com/a-voityuk/react-native-native-video-player/commit/94fae9b517d67282bc829eeef494106e016458f4#diff-cab10c893122a0d34bad65887e67ff15

This would resolve #26 and avoid any of the steps needed in #4

DriesVS commented 5 years ago

@ericmgoeken @BondGoat What's the status on this? It would be nice to see this get merged.

ericmgoeken commented 5 years ago

@DriesVS, I am just waiting on @BondGoat or someone with the ability to merge.

I am just pointing my package.json to my fork right now.

ericmgoeken commented 5 years ago

@BondGoat, Thanks for merging those in.