search

BondGoat / react-native-native-video-player

React native video player, used for Android, iOS. It will lauch a Native Video, not an Embeded Component
GNU General Public License v3.0
50 stars 44 forks source link

iOS native module does not match #31

Open DriesVS opened 5 years ago

DriesVS commented 5 years ago

the JS implementation looks for a native module named VideoPlayerManager but the Obj-c class is named RNVideoPlayer without a custom name. This does not even work. Currently wrote my own interface, I can create a PR for this to get it to work. But how can this even be in production?

ericmgoeken commented 5 years ago

I had noticed this when I first pulled this down too. I should have made a pull request sooner.

@BondGoat, while that merge button is still warm, here is another.