I tend to prefer to work with specific Service ID's, rather than pulling all trips with a specific date. Ideally, the user could pass either a list of Service IDs, or start/end dates w/ the busiest flag in order to filter trips effectively. I put together a branch to do so. I split off the 'busiest date'-parsing logic into a helper function, which returns a list of service ID's for the get_trips function to parse, so get_trips always just parses a list of service ID's, whether it pulls them from the busiest date or gets them directly from the user.
If this change is in line with the approach of the broader project, I'm happy to clean up my branch a bit and open a PR (my apologies if I'm approaching this wrong, I'm mostly self-taught in terms of programming).
I tend to prefer to work with specific Service ID's, rather than pulling all trips with a specific date. Ideally, the user could pass either a list of Service IDs, or start/end dates w/ the busiest flag in order to filter trips effectively. I put together a branch to do so. I split off the 'busiest date'-parsing logic into a helper function, which returns a list of service ID's for the get_trips function to parse, so get_trips always just parses a list of service ID's, whether it pulls them from the busiest date or gets them directly from the user.
If this change is in line with the approach of the broader project, I'm happy to clean up my branch a bit and open a PR (my apologies if I'm approaching this wrong, I'm mostly self-taught in terms of programming).