Bonfida / agnostic-orderbook

Apache License 2.0
79 stars 33 forks source link

Add a feature flag that makes `pub(crate)` function and structs `pub` #87

Closed Henry-E closed 2 years ago

Henry-E commented 2 years ago

For those of us who like to live dangerously it would be nice to have the option to access functions / structs that are private to the crate, i.e. pub(crate). Hiding it behind a feature flag would stop the unaware from accessing them.

It would just be great if there was a way to access some of these functions / structs without having to fork the repo just to remove (crate).

ellttBen commented 2 years ago

Hi @Henry-E, I understand your concern here. There would be two ways to tackle this, but I'm not sure I am fond of either one :

This means that my current view on this is that playing around with library internals is really what forks are for. You don't need to remove (crate) instances when you can just add your custom code directly to your fork.