BoniatoRelleno / CustomPaintings

0 stars 0 forks source link

[Request] add support for additional CustomPaintings folders #1

Open ajsglist opened 5 months ago

ajsglist commented 5 months ago

in order to allow mod manager support/syncing to be as easy as possible, it would be great if CustomPaintings supported an alternate source of "CustomPaintings" folder from another mod (and ideally allowed for disabling the 8 base CustomPaintings images)

Thanks for the consideration

BoniatoRelleno commented 5 months ago

Hi! First of all, thanks for your suppport <3

Regarding your proposals, I will make a configuration file with an option to change the directory.

You already can delete the base images, them are only created the first time you open the game with the creation of the CustomPaintings directory.

ajsglist commented 5 months ago

You already can delete the base images, them are only created the first time you open the game with the creation of the CustomPaintings directory.

Unfortunately, I don't think this level of control is available via mod manager. Though it's possible I'm missing something.

BoniatoRelleno commented 5 months ago

If you are ussing r2modman you can do it anyway. Go to settings and click browse profile folder, then in the file explorer window go to BepInEx\plugins\CustomPaintings and delete the default images, now put in that folder the custom paintings that you want

ajsglist commented 5 months ago

Thanks for the update, now I see what you mean.

Unfortunately, I don't think this will sync between clients -- sharing a modmanager code will only pull the mod list and configs (unless I'm misunderstand that?)

No worries either way, I'm content waiting for an update that handles it directly.

Thanks again :)

BoniatoRelleno commented 5 months ago

What I mean by synchronization is that everyone will see the same texture as long as everyone has the same paintings in that folder, automatically syncing the host's paintings with all clients would be much more complex. So make sure that all the clients put the same images with the same names in that folder to work properly.

Thanks you again too :)

BoniatoRelleno commented 5 months ago

Oh I just realized that you mean synchronizing just by sending the code, to do that you would have to make a mod that already contains the paintings, it is not complicated, if you don't know how I can help you

ajsglist commented 5 months ago

In order to do that, wouldn't I need to essentially repack your mod with my own paintings? If that's not what you're talking about, I'd love more information.

But if that's what you mean, I think my original post might be the best solution. I can refer back to your release of CustomPaintings as a dependency while supplying the replacement paintings in a community pack (this is the same method used for other custom content -- suits, cosmetics, custom boombox tracks, etc). Prevents any potential errors and makes using any updated versions of CustomPaintings a breeze.

BoniatoRelleno commented 5 months ago

That's what I mean, I understand that the problem is that the default paintings would continue being. I'll keep it in mind when making the configuration file, don't worry :)

cfazilleau commented 5 months ago

Hi ! I saw in the code of your plugin that you download the different images for the paintings using imgur URLs. A suggestion I have is to move this to a config file, this way we could edit the links of the images we want the plugin to download, and also share it via code, as the config files are included when sharing by code. Another line in the config file could be a boolean to force download the images at every launch, to ensure that everyone is up to date and prevent the mod from having to check the existing files everytime. Tell me what you think about those ideas, I would gladly have done it myself and submitted a PR, but your code seems to be closed source

BoniatoRelleno commented 5 months ago

Hi, thanks for the ideas, I'm going to work on it right now :)

BoniatoRelleno commented 5 months ago

I just published the update! :)

Don't worry about the default paintings because I added an option to disable them even if are already downloaded

cfazilleau commented 5 months ago

Amazing ! I'll give it a try