search

BonkeGcobo / AwesomeBooks

The first project in the JavaScript module, the project is created using mostly JavaScript
https://bonkegcobo.github.io/AwesomeBooks/
6 stars 0 forks source link

Add and remove books feature #1

Closed BonkeGcobo closed 2 years ago

BonkeGcobo commented 2 years ago

We created a medium-fidelity wireframe to implement the "add and remove" feature of the awesome books app.

mimipeshy commented 2 years ago

Hello @BonkeG 👋,

This is an additional review as a result of the second opinion request.

Hi there, as the previous CR stated, your app does not remove the correct book, this is because the books do not generate a unique id, all the books have the same id, so if I remove id 1, and it should be id 4, it removes all books with id 1 regardless of whether the title is the same or not. Check out the screenshot below ⬇️

image if I want to remove book id 3 it will remove all the other books as well since they share the same id. I should only delete the correct book which is book id 3. Does this make sense? This is what I get after deleting the book which should be id 3 ⬇️

image

Kindly fix the id issue so that each book generates its own id, this should be able to solve the issue you are having. Don't forget to submit another review when done in your dashboard. 👍🏾

Keep rocking 🚀!