search

BonnyCI / projman

A project management repository -- meta
0 stars 2 forks source link

API Commands to github are not retried. #200

Closed gandelman-a closed 7 years ago

gandelman-a commented 7 years ago

Our github API requests do not get retried on failure. In one instance, a temporary network blip prevented Zuul from updating the status after a check job finished. From the PR POV, the job never completed and was still running (a yellow pending button on the check). The user was left wondering what was going on since the Zuul status page correctly did not report it as running. We should probably retry API commands that fail for network related issues, and probably some others?

There's a newer library in use in openstack that may make this super easy, just wrap the functions in connection/github.py https://github.com/jd/tenacity

omgjlk commented 7 years ago

Should be fixed once zuul is restarted.