search

BonsaiDen / JavaScript-Garden

A collection of documentation about the most quirky parts of the JavaScript language.
http://bonsaiden.github.com/JavaScript-Garden
MIT License
3.45k stars 559 forks source link

Updates from the Russian translation #369

Open shamansir opened 7 years ago

shamansir commented 7 years ago

These ones were away for years, since I was improving our fork of translation back in 2014 without making an actual PR. It's probably one of the reasons why googling the original returned the Russian result at a second place (https://github.com/shamansir/JavaScript-Garden/issues/5) after the original for some time. These include a lot of important stylistic fixes, while may (unfortunately) introduce some outdated things, so needs a close review from Russian colleagues.

I plan (finally) to delete my outdated "mirror" (actually, to replace it with a Disclaimer and a proper link to the original, because a lot of Russian resources still refer to my version), but I think it's important to move these language-related fixes to the original, in this case.

~Since it conflicts with master, I'll try to review the changes required to make it fit.~

shamansir commented 7 years ago

Seems, together with upgrades there were some downgrades introduced. I will review the changes again and re-open this PR when the style fits my current standards.

shamansir commented 7 years ago

@koliada, @lhms, @andrepolischuk, @inomdzhon, @creamov All of you made the contributions/fixes to the Russian Translation in this repository (I reassured I included and fixed all of them using this history). Could you please review this one, when you have a chance?

Here I try to get rid of the "subscript translation" feeling, in the places I failed to notice almost ten years ago :).

peterjwest commented 7 years ago

Thanks for doing all this! Hopefully we can get someone to review as it is a big change and I don't speak Russian

timruffles commented 7 years ago

@shamansir thanks for the effort, really appreciated 👏!

How close is this to being shippable?