BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.02k stars 1.88k forks source link

Inline commenting #1265

Open abbeyjackson opened 5 years ago

abbeyjackson commented 5 years ago

This is a suggestion added to issues as per Dan’s instructions via Twitter.

Inline commenting (selecting a chubk of text to comment on or having a comment associated with a specific line number) is a feature that is missing from Bookstack which I feel would really add value to the product.

JohnnyWild89 commented 4 years ago

Looking forward to get this feature! Bookshelf is perfect replacement for any products which use as WIKI. Inline commentaries would greatly expands work possibilities.

cze-karel commented 3 years ago

This would be a really great feature that would improve the possibility of people collaborating on the documents. Is it possible this feature will make it into the roadmap?

ssddanbrown commented 2 years ago

Further request and ideas proposed within #3063

TiemeWoldman commented 2 years ago

Any plans on adding annotations (Inline comments) to BookStack? This would be a great addition.

I tried hypothes.is for adding annotations to BookStack pages, but the BookStack text select pop-up interferes with hypothes.

EDMJohnny commented 2 years ago

As far as I can tell BookStack is pretty close to perfect for a writing / collaboration platform. Super simple to use, very intuitive. Inline comments would make it perfect! Is this something you are working on or have an ETA for? Thanks

ssddanbrown commented 2 years ago

@EDMJohnny

Is this something you are working on or have an ETA for?

Not at this time.

EDMJohnny commented 2 years ago

Thanks for responding. Is this something you'd be willing to put a bounty on / get paid for completing? Do you have a ballpark for cost of adding this feature?

ssddanbrown commented 2 years ago

@EDMJohnny I'm not really a fan of public bounties, can just cause issues. Not really sure on ballpark costs either as this would need fleshing out into a full proposal since this request could be imagined/desired in different forms.

I've quoted features before (although never accepted) but only for features with clear scope and platform fit. Something makes me uneasy about rushing through a proposal for the sake of money, feel that risks providing an unbalanced larger voice to those with money, not sure the right way to balance that. If I was to quote it'd be somewhere upwards of £1k, even for a minimal implementation.

danhansen commented 2 years ago

Why not integrate something like https://github.com/recogito/recogito-js ? It looks like a significant portion of the functionality is already implemented.

BloodyIron commented 2 years ago

@ssddanbrown can we please have this added to a roadmap in some regard? As you may remember seeing me elsewhere, likely to switch to Bookstack, and some of our staff use this kind of feature in Confuence (which we are moving away from).

Is there a hurdle on your end for this?

ssddanbrown commented 2 years ago

Is there a hurdle on your end for this?

Uh, I guess it's some level of formula of:

PRESSURE = ("user actual benefit" + "user demand" + "my own enthusiasm level for the feature")
DRAG = ("implementation cost" + "my predicated cost of maintenance, inc. support")
HURDLE = ((PRESSURE - DRAG) * "my current emotions" * RANDOM_CHANCE())

That's probably the best I can explain it, same for any feature tbh. Roadmap is reserved for high-level elements. Could maybe have some kind of "Commenting and Communications" item. Not sure though, might want to address other things before.

Realistically, the next step for this specific request would be for me to put forward an implementation proposal, with a scope that I'd be happy to maintain, for community feedback. No reason to rush though IMO.

ironbelly commented 1 year ago

Agreed with EDMJohnny above that inline comments to facilitate more specific conversation amongst collaborators is one of the biggest items of value that could be added.

Also inline with EDMJohnny about the bounty, would be happy to chip in

EDMJohnny commented 1 year ago

@ssddanbrown Hi - just checking in again. I see you've done a lot of updates on Bookstack since I last checked it. All much appreciated. Any chance of bumping this feature request for inline comments on to your To Do?

ipimpat commented 1 year ago

This would be a killer feature !

rosequaartz commented 1 year ago

This feature would be great! :)

shashankvivek commented 1 year ago

Yeah, with this feature, bookstack can knock the ball out of the park !

stevenvegt commented 8 months ago

I stumbled on this issue and wanted to chip in. We use bookstack for our open source community. People are working together on projects and keep reverting to google docs. Inline comments are the missing key in bookstack and holding them back to make the switch. I hope this will add some weight to the"user actual benefit" + "user demand" parts of the equation. Either way, thanks for this nice piece of software!

dtufood-kihen commented 5 months ago

Just dropping by to say I've been keeping an eye on the chat about inline comments. I get that developers have to juggle a bunch of stuff and can't just jump on every new idea, but I can't help feeling pretty stoked about this particular feature.

Please make it happen ! :-)

khudari-starpath commented 5 months ago

+1 would switch to bookstack if it had this feature!

agapoar commented 3 months ago

Hi. I would also love to see this feature added. By way of suggestion, I expected to see the ability to add an inline comment when I double clicked on a word in the text in read mode. I did see a popup menu, which was great. But obviously it didn't contain the ability to annotate. This screenshot shows the menu.

image

ipimpat commented 3 months ago

Hi @ssddanbrown,

First, I want to express my gratitude for the incredible work.

I was wondering if you might consider adding the annotation feature to the roadmap. The demand for this feature seems quite high among users.

Currently, the absence of this feature is the main reason my team continues to rely on Word files. They are hesitant to transition to tools that lack annotation capabilities.

Thank you so much for considering this request, and for all the amazing work you continue to do.

bendem commented 3 months ago

The demand for this feature seems quite high among users.

If you look at the most requested feature, it has >100 👍🏻. This one has 25.

Reminder that adding a 👍🏻 on the top post is the way to vote for an issue, pressuring/guilting the developer is not the way to get the feature you want added in.

image

grv688 commented 2 months ago

Also very interested in this. We're migrating from documents that allowed inline commenting during revision cycles, and it was very useful.

pato-lama commented 1 month ago

Tossing a comment in here to support this request - would love having this functionality!

ahnchive commented 1 week ago

Also very interested in this!