BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.3k stars 1.91k forks source link

Bug: Drawing gets saved as an image if on bulletpoint #1304

Open chasgames opened 5 years ago

chasgames commented 5 years ago

Describe the bug When you create a diagram on a bulletpoint in the editor, then Save the diagram, it is saved as a PNG image rather than a diagram.

Steps To Reproduce Steps to reproduce the behavior:

  1. Create bullet point list, image
  2. Click Drawing
  3. Draw something
  4. Click Save
  5. Can't re-edit Drawing, saved as PNG image. Even if bullet points are then removed.

Expected behavior Saved as as an editable diagram

Screenshots image

Your Configuration (please complete the following information):

chasgames commented 5 years ago

Saw a few other scenarios where the drawings becomes uneditable, Numbered points, and inside a Table. Is this expected?

ssddanbrown commented 5 years ago

Thanks for raising @chasgames.

Is this expected?

No, just not something that's been tested to this degree, Will have a think about where images should be supported.

By the way, All drawings are actually saved as PNG images with drawing data embedded, Just looks like these are no structured or detected properly as drawings when in other elements.

chasgames commented 5 years ago

Great thanks Dan, good to know the drawing data is still embedded :)

ssddanbrown commented 5 years ago

:+1: As a backup, If you have any existing drawings you need to save you should be able to right-click them > download to your pc. Then in draw.io go to File > Open from > Device, then select your drawing file.

Wookbert commented 3 years ago

Just ran into the same problem, and thought I should report ... but it already has been. Luckily I still had the drawing in the clipboard. image image