search

BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.2k stars 1.9k forks source link

Clean up code suggestion for permission system and etc. #1528

Closed imanghafoori1 closed 5 years ago

imanghafoori1 commented 5 years ago

Hi, I reviewed your code base and saw that you can clean up and make it more flexible and modular using my open-source laravel packages, (like : laravel-widgetize, laravel-heyman, laravel-decorator)

I can create PRs for you, but before that I wanted to ask if you allow for additional composer dependencies in pull requests or not ?

ssddanbrown commented 5 years ago

Thanks for the offer @imanghafoori1 but I'd prefer not to increase the dependencies without clear requirement or benefit to the project.

imanghafoori1 commented 5 years ago

Of course it has clear benefits for code quality, but it still depends on the fact that how much you want your code to be cleaned up, or you are happy with it, that it just works.

I am curently doing a full rewrite on https://github.com/thekordy/ticketit to make it fully modular. It will be released in a few days. You may inspire from it.

ssddanbrown commented 5 years ago

Yeah, that's fair but familiarity, style and opinion also factor in I think. I'll close this for now but feel free to add a comment with a link to your re-write, once done, as I'm always interested to see real-life code organisation patterns.