BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.22k stars 1.9k forks source link

Copying a page doesn't copy the contents to the new page. #2463

Closed nickolasdeluca closed 3 years ago

nickolasdeluca commented 3 years ago

Describe the bug After I updated from v0.30.3 to v0.31.1 I noticed that when I copy a page, it's contents are not copied over.

Steps To Reproduce Steps to reproduce the behavior:

  1. Create a page, type anything into the contents of the page, give it a name and save.
  2. On the new page you just created, click on copy on the left sidebar, give it a new name and save.
  3. The new page has the name you just typed, but it is empty.

Expected behavior It should copy the contents of the page over to the new one, just as it did on v0.30.3.

Screenshots If applicable, add screenshots to help explain your problem.

Your Configuration (please complete the following information):

Additional context I had a problem when updating my bookstack instance last time, where my database was behind on a couple of migrations, even though my database had the fields and tables that the missing migrations should add, I then created the migration records manually and tried to update again, which fixed the issue and I managed to update with no issues.

ssddanbrown commented 3 years ago

Thanks for reporting @nickolasdeluca.

Can confirm this is occurring when no markdown content exists on a page. Have marked as a priority to be fixed as part of the next patch release.

nickolasdeluca commented 3 years ago

Oh thank god it wasn't something I've done while fixing the migrations issue. haha

Looking forward to the fix, meanwhile I'll copy things manually.

ssddanbrown commented 3 years ago

This has been patched in 526be33ab2a88609e0178187e013e22081263ee3 with updated testing to cover. This will be part of v0.31.2 which should be released sometime today. Therefore I'll close this off.