BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.36k stars 1.92k forks source link

"Save Draft" doesn't work when editing tags #4110

Closed rgkirch closed 1 year ago

rgkirch commented 1 year ago

Describe the Bug

In order to add a tag to a page, I have to first click the "Edit" action so that I'm editing the document. Then there's a 🏷 "Page Tags" button in the right sidebar that expands a "Page Tags" window. After typing in a new tag, <ctrl+enter> doesn't do anything and <ctrl+s> triggers the browsers default "Save As" dialog to download the html page. I expect <ctrl+enter> (Save Page & Continue) and <ctrl+s> (Save Draft) to do the same thing they do when my focus is in the wysiwyg editor.

Steps to Reproduce

edit a document image add a tag image finish typing name of tag image press <ctrl+enter> or <ctrl+s>

Expected Behaviour

ctrl+enter should do the same thing it does when you're editing the document ctrl+s should save the tag but allow you to continue editing the document

Screenshots or Additional Context

No response

Browser Details

chrome 111.0.5563.65 windows 10

Exact BookStack Version

BookStack v23.02.1

PHP Version

8.2 from php:8.2-apache-buster from solidnerd/bookstack:23.2.1

Hosting Environment

solidnerd/bookstack:23.2.1 docker

ssddanbrown commented 1 year ago

It's not so much a bug, but the fact that the save-draft system only relates to page content itself, and the save draft shortcut is only within editor; nothing related to the page or things in the sidebar/toolbar uses the draft system.

There's possibly reason though to make this clearer to the user, but not sure on a clean non-distracting to do that. This is also the first time I can think of in the last 6 or so years that that has been raised, so not sure how significant of an issue it is.

ssddanbrown commented 1 year ago

Since this isn't a bug, as mentioned above, and since this hasn't really been reported to be a UX issue in the past I'm going to close this off.