Attachment upload validation error message appears are shown as JSON

BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel

https://www.bookstackapp.com/

MIT License

15.49k stars 1.95k forks source link

Attachment upload validation error message appears are shown as JSON #4996

Closed ssddanbrown closed 6 months ago

ssddanbrown commented 6 months ago

Can reproduce via uploading a file larger than the app upload limit. Could do with reducing line-height here to provide more room for text too.

KiDxS commented 6 months ago

Hey @ssddanbrown,

Can I work on this issue?

ssddanbrown commented 6 months ago

@KiDxS Sure! But only if you're able to do so fairly soon (by the end of tomorrow) since this is assigned to the next patch already which I'm hoping to release soon, otherwise I'll take it back on.

KiDxS commented 6 months ago

Thanks for letting me know, Dan!

I'll start working on it after I get home in 2 hours.

If I don't finish it by the end of tomorrow. Feel free to take it back on.

KiDxS commented 6 months ago

Hi @ssddanbrown ,

I don't think I can fix this by the end of tomorrow.

I think I bit more than I can chew.

Feel free to take it back on.

ssddanbrown commented 6 months ago

Thanks for updating me @KiDxS. I've now addressed this via 72c5141decb1d83910a81fd0c4bf77f4a463ce5c, to be part of the next patch release.