BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
14.79k stars 1.86k forks source link

Images Select tool won't load images #5108

Open malewpro opened 1 month ago

malewpro commented 1 month ago

Describe the Bug

Yesterday while editing a page on my local instance of Bookstack I tried to add images to the page. I ran into file issues while uploading (missing headers for jpegs). After resolving the file issues I went to upload the photos again and now the Image Select panel is stuck loading the previously uploaded images and no further uploads succeed.

Screenshot 2024-07-08 at 5 51 25 PM

The only items in the Bookstack Logs are:

nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /config/nginx/site-confs/default.conf:7

And the only items in the DB logs are:

[custom-init] No custom files found, skipping...

240707 19:24:24 mysqld_safe Logging to '/config/databases/f35135a15412.err'.

240707 19:24:24 mysqld_safe Starting mariadbd daemon with databases from /config/databases

Connection to localhost (127.0.0.1) 3306 port [tcp/mysql] succeeded!

[ls.io-init] done.

Steps to Reproduce

  1. Attempt to upload .jpeg files with file issues using the Image Select tool in the page editor.
  2. Close the panel and save the page.
  3. Attempt to upload photos to the page again.

Expected Behaviour

Previously uploaded images should appear in the Image Select panel, and new photos should successfully upload.

Screenshots or Additional Context

No response

Browser Details

Firefox 127.0.1 (64-bit)

Exact BookStack Version

BookStack v24.05.2

ssddanbrown commented 1 month ago

I ran into file issues while uploading (missing headers for jpegs). After resolving the file issues [...]

malewpro commented 1 month ago

Hey apologies for the slow response!

What exactly do you mean by this? What did you change to resolve this?

I airdropped photos from my iPhone which came in .HEIC format. I used the MacOS Preview app to re-export them as jpegs. It seems as though something went wrong with the export, but I'm not quite sure what. I've done that process before and the images have uploaded to Bookstack without issue. I attempted to fix it by deleting the incorrect exported images and re-exporting them with slightly different compression settings. I believe this fixed it, but I can't be sure as the upload dialogue still isn't working for me.

Can you provide details of the jpeg you uploaded that led to this? (file size & image dimensions).

The image dimensions were 5712 × 4284, and the size was around 2-3MB depending on the image.