BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.47k stars 1.94k forks source link

Assess if we can avoid putenv usage to avoid some thread safety issues #5126

Open ssddanbrown opened 4 months ago

ssddanbrown commented 4 months ago

In thread error-prone environments (Apache on XAMPP windows by default for example) there can be issues with things like config loading, where config ends up blank.

This can be helped by config caching as a workaround, which we don't advise/document, but I feel it's better to avoid such thread problematic scenarios completely where possible, which it looks like it may be:

https://github.com/laravel/framework/pull/28908 https://github.com/laravel/framework/pull/28740

From what I can tell, this could effect libraries that use putenv/getenv, so might need to think-about/audit potential impacts there.