Open ssddanbrown opened 1 month ago
@ssddanbrown I would love to test it out, but I don't see yet any v24.10 release.
@AvrumFeldman I'm just preparing its release now, for later this week (Created this so I could link to it from the update blogpost)
Bookstack v24.10 released a few hours age and i unfortunately found a bug. Not sure if i had to post it here so ill post the link: https://github.com/BookStackApp/BookStack/issues/5249.
I found a few differences in the way lists are handled:
This wasn't supposed to be only about lists, but here we are.
Hi @ssddanbrown First of all, thank you very much for your work. I started watching the release video but haven't managed to finish it yet. It is possible that it has already been mentioned there.
I have also a question.
I was able to customize the buttons with the old tinymce version. For this, I had added this line into the customization: <script src="/js/custom.js"></script>
and added in the corresponding directory my code to add a "clear format" button on the top level menu and also to add a shortcut ctrl+shift+u for clear format. Hopefully, this feature will also be implemented to customize the new editor buttons, if needed? It would be very nice, to have this feature also in the future to customize the editor.
Here's my code which I have used to modify the buttons:
window.addEventListener("editor-tinymce::pre-init", (event) => {
const mceConfig = event.detail.config;
mceConfig.toolbar += " clearformat";
});
window.addEventListener("editor-tinymce::setup", (event) => {
const editor = event.detail.editor;
// Registriere das Icon mit validiertem SVG-Code
editor.ui.registry.addIcon(
"clearformaticon",
`<svg xmlns="http://www.w3.org/2000/svg"
width="24" height="24"
viewBox="0 0 496 496" xml:space="preserve">
fill="currentColor">
<path style="fill:#DD3E95;" d="M363.6,224V37.6C363.6,15.2,348.4,0,326,0H169.2c-22.4,0-37.6,15.2-37.6,37.6V224H363.6z"/>
<path style="fill:#BC086B;" d="M131.6,224h232V37.6C363.6,15.2,348.4,0,326,0H179.6"/>
<path style="fill:#2F96C9;" d="M131.6,272v186.4c0,22.4,23.2,37.6,45.6,37.6h149.6c22.4,0,37.6-15.2,37.6-37.6V272H131.6z"/>
<path style="fill:#207EB7;" d="M181.2,272l-49.6,186.4c0,22.4,23.2,37.6,45.6,37.6h149.6c22.4,0,37.6-15.2,37.6-37.6V272H181.2z"/>
<rect x="131.6" y="224" style="fill:#FFFFFF;" width="232" height="48"/>
<rect x="179.6" y="224" style="fill:#EFE6D8;" width="184" height="48"/>
<rect x="275.6" y="224" style="fill:#DDD3C5;" width="88" height="48"/>
<path style="fill:#095A91;" d="M179.6,272v224H326c22.4,0,37.6-15.2,37.6-37.6V272H179.6z"/>
<path style="fill:#044D7F;" d="M179.6,496H326c22.4,0,37.6-15.2,37.6-37.6V272"/>
<path style="fill:#911743;" d="M326,0H179.6v224h184V37.6C363.6,15.2,348.4,0,326,0z"/>
<polyline style="fill:#7F113E;" points="179.6,224 363.6,224 363.6,40 "/>
</svg>`
);
// Füge den Button hinzu
editor.ui.registry.addButton("clearformat", {
tooltip: "Formatierung entfernen (Ctrl/Cmd+Alt+U)",
icon: "clearformaticon",
onAction() {
editor.execCommand("RemoveFormat");
},
});
// Shortcuts hinzufügen
editor.addShortcut("ctrl+alt+u", "Formatierung entfernen", () => {
editor.execCommand("RemoveFormat");
});
// macOS
editor.addShortcut("meta+alt+u", "Formatierung entfernen", () => {
editor.execCommand("RemoveFormat");
});
});
@thegatesdev Thanks, lists are deceivingly complex :sweat_smile:
Do you have a use-case/need for empty (space only) lists? Just thinking on the balance of matching the new editor, vs potential convenience in treating whitespace only items as empty.
@miracuruzrh Thanks! Had meant to note the lack of dark mode support but had forgotten by release!
In regard to customizations/hacking, that's not something I'm considering right now in the earlier alpha/beta stages, but maybe it's something that can be discussed in the later stages toward when it's becoming the default, when internals/development has stabilised a bit.
Do you have a use-case/need for empty (space only) lists?
One use-case I can think of is when using numbered lists, when writing content from elsewhere that is already numbered, you can skip one entry (for later) by leaving it empty and preserving the numbering for the next. Since it's basically the standard behaviour (both in Office 365 and Google Docs) I feel like keeping this would be nicer for the user.
lists are deceivingly complex
I realized that while testing, best of luck with the implementation 🙏🏼 🥲
@thegatesdev Thanks, lists are deceivingly complex 😅
Do you have a use-case/need for empty (space only) lists? Just thinking on the balance of matching the new editor, vs potential convenience in treating whitespace only items as empty.
@miracuruzrh Thanks! Had meant to note the lack of dark mode support but had forgotten by release!
In regard to customizations/hacking, that's not something I'm considering right now in the earlier alpha/beta stages, but maybe it's something that can be discussed in the later stages toward when it's becoming the default, when internals/development has stabilised a bit.
Hi @ssddanbrown Many thanks for your reply. Sure, I fully understand. Important things first. If needed, we can always go back to the earlier editor.
Hi Dan, you may already be aware of this regarding collapsible blocks:
Migrated Page
New Page
Additionally (These may be better suited as a dedicated feature requests),
I've really been enjoying Confluence's latest editor whereby you can use Markdown shortcuts as you type.
#<space>
automatically converts it to Heading 1
---
inserts a horizontal rule```
creates a code blockSeparately, the /
to list and search for page components is quite useful too.
Hello! To echo the comment from @beanaroo above, I would love to see shortcuts that are a hybrid between typing raw markdown and using the WYSIWYG editor, in the same way that typing an asterisk before a line will automatically convert it into a list.
I think having the following markdown-style shortcuts would be extremely helpful:
hello
```
) and pressing enter to create a new code block (the same as TinyMCE's shortcut "meta+7")---
) and pressing enter to create a horizontal rule#
) and a space to convert the current line into a heading
#
= H1, ##
= H2, ###
= H3, etc.Thanks @beanaroo, have added those notes regarding collapse block issues.
@beanaroo @ttepatti I consider new functionality outside the scope of this issue, and in regard to markdown based auto-conversion/formatting specifically, this has been touched upon previously in #2025 and my feelings are much the same. Would be more open to making that kind of thing possible via an unofficial hack, once the editor is more stable/mature.
This is a thread specifically to collect feedback regarding issues and limitations of the new WYSIWYG editor, introduced in BookStack v24.10.
This below list will be continuously updated from feedback to form a full listing to be worked on. Please only report issues where not already in this list. Generally our goal is to match the existing TinyMCE based editor as close as possible.
Known Issues