search

BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.43k stars 1.94k forks source link

Add theme category in settings page #5251

Closed LachTrip closed 1 month ago

LachTrip commented 1 month ago

Attempted Debugging

Searched GitHub Issues

Describe the Scenario

Trying to make an additional settings page for my bookstack theme. I can add a new category to settings.layout and have a custom settings page, but to be able to access it I need to add an entry to the settingCategories in app/Settings/SettingController.php, which does not seem possible through current theming options.

Exact BookStack Version

v24.03-dev

Log Content

No response

Hosting Environment

Debian docker

ssddanbrown commented 1 month ago

Hi @LachTrip, Yeah, the categories are not made customizable in any way.

I guess we could change this up so, instead of validating the categories by fixed array, we could validate them by checking for an existing matching view file. Would probably be best to move the existing setting category layouts into their own view folder though to prevent any pollution in that respect.

ssddanbrown commented 1 month ago

Now achieved via your PR #5255, thanks again @LachTrip!