Space above header bar - Githubissues

BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel

https://www.bookstackapp.com/

MIT License

15.12k stars 1.89k forks source link

Space above header bar #5266

Open bfruben opened 1 day ago

bfruben commented 1 day ago

Describe the Bug

When making my own theme and changing some phrases I ended up with extra space above the titlebar.

This space only appears when I change copy and change the entities.php in the themes folder.

Steps to Reproduce

Make your own theme
Copy the entities.php from /lang/sv to /themes/theme_name/lang/sv
Change the entities.php file
Reload Bookstack with the custom theme

Note: When copying entities.php to the themes folder and not changing it, the extra space does not appear.

Expected Behaviour

No extra space above the titlebar

Screenshots or Additional Context

No response

Browser Details

Edge

Exact BookStack Version

BookStack v24.05.4

ssddanbrown commented 1 day ago

Note: When copying entities.php to the themes folder and not changing it, the extra space does not appear.

What exactly are you changing which makes the space appear?
Are there any other files within your theme folder?

Just a note, you don't need to copy in the while file if you don't need to alter most translations, you can just add/override the translations as needed.

bfruben commented 1 day ago

Note: When copying entities.php to the themes folder and not changing it, the extra space does not appear.

What exactly are you changing which makes the space appear?

Are there any other files within your theme folder?

Just a note, you don't need to copy in the while file if you don't need to alter most translations, you can just add/override the translations as needed.

Any change I make the space appears.
These are the only files I have in the themes folder right now:

Thanks for the tip! I was removing everything that I didn't want to change. That's how I discovered this "bug". ;)

ssddanbrown commented 21 hours ago

Thanks the the response @bfruben, I can't reproduce this, nor does it make sense really. I can only think the structure of the file is being modified in some way, casing stray text to be emitted at the start of the page/document.

With just one language override file active:

Does the file still have just one <?php at the very very start of the file?
Does the text ?> exist in the file at all?
Is there any text in the top left corner within that added space (Try highlighting that area if you can't see any)?