BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.43k stars 1.94k forks source link

simpifly Dockerfiles #5293

Open johnroyer opened 3 weeks ago

johnroyer commented 3 weeks ago

some updates:

Notes: everything should be works on docker compose up

ssddanbrown commented 3 weeks ago

Thanks for offering this @johnroyer but I personally prefer the original means of installing extensions and composer to be honest, rather than getting another container and external script involved.

johnroyer commented 3 weeks ago

How do you think if I revert the commit of php extension installer ?

ssddanbrown commented 3 weeks ago

Assuming that reverts both composer and extension install changes, then yeah should be good. Just an FYI, I'll probably squash merge this rather than having (potentially) 7 commits for altering a single file.

johnroyer commented 3 weeks ago

Assuming that reverts both composer and extension install changes

OK, i will revert both

I will rebase onto develop before push.

johnroyer commented 3 weeks ago

I merge changes to 2 commits. Seems everything is fine on build.