BookStackApp / BookStack

A platform to create documentation/wiki content built with PHP & Laravel
https://www.bookstackapp.com/
MIT License
15.45k stars 1.94k forks source link

Improve error handling of synchronous notifications #5315

Open ssddanbrown opened 1 week ago

ssddanbrown commented 1 week ago

Notification email sending failures, without using a queue/worker currently throw and block the process, showing the error view. Since email requires the network, and SMTP servers can respond in various unexpected ways, and since notifications sending issues probably wouldn't be considered an essential error to the majority of cases, would should probably instead attempt these but catch & log errors, to allow the action within BookStack to continue as expected.

Related to support thread 125

Doc Updates

Probably worth documenting error behaviour on the docs page.