search

BookingSync / synced

Keep your BookingSync Application synced with BookingSync
MIT License
3 stars 2 forks source link

Add auto_paginate to options #70

Closed StoneFrog closed 7 years ago

StoneFrog commented 7 years ago

To be merged after #69

Fredar commented 7 years ago

Whats the usecase of forcing auto_paginate to false?

StoneFrog commented 7 years ago

@Fredar There is another PR to make it possible to switch between using auto_paginate (so fetching and saving everything at once) and pagination with blocks (saving batch after each request). As Manda didn't want all of that mixed up in one PR I extracted it here. So to provide backwards compatibility, but at the same time to allow quick switching between auto_paginate and pagination with blocks for testing, I decided to add this option. Also since before merging this other PR passing auto_paginate: false would probably break something, I didn't update any docs here.

If it's a bit too confusing I may add this option after this other PR is merged.

Mandaryn commented 7 years ago

this is going to be configurable shortly with block pagination, extracted here to make the other pr smaller