Bookingjini-Tech / bookingjini-icons-archive

Find hospitality related icons, curated by creators from Bookingjini
https://icons.bookingjini.tech
MIT License
44 stars 116 forks source link

Adding icons to navbar #131

Closed vipulpandey7860 closed 1 year ago

vipulpandey7860 commented 1 year ago

Please describe the problem The nav bar links doesn't have icons. Being an icons website nav bar elements should have icons.

Describe the solution you'd like Adding the icons for lignt/dark theme, download and get cdn button.

vipulpandey7860 commented 1 year ago

please assign this issue to me under gssoc'23

bookingjini commented 1 year ago

Please describe the problem The nav bar links doesn't have icons. Being an icons website nav bar elements should have icons.

Describe the solution you'd like Adding the icons for lignt/dark theme, download and get cdn button.

Thank you, @I-VipulPandey, for your reply. Could you please share a prototype or design sample illustrating the changes you intend to contribute? This will help us better understand the modifications you wish to make to the repository.

vipulpandey7860 commented 1 year ago

Please describe the problem The nav bar links doesn't have icons. Being an icons website nav bar elements should have icons. Describe the solution you'd like Adding the icons for lignt/dark theme, download and get cdn button.

Thank you, @I-VipulPandey, for your reply. Could you please share a prototype or design sample illustrating the changes you intend to contribute? This will help us better understand the modifications you wish to make to the repository.

The current design of nav bar doesn't give user all the details, thus by adding icons on nav bar and displaying them when hovered user can get more details what function will the following button will do. I am attaching a video of what I exactly ment, I can also change it if you have something specific.

https://github.com/Bookingjini-Labs/bookingjini-icons/assets/53248489/7bfb80a6-ae75-4d1c-a762-166a74669eee

AshutoshDash1999 commented 1 year ago

Please describe the problem The nav bar links doesn't have icons. Being an icons website nav bar elements should have icons. Describe the solution you'd like Adding the icons for lignt/dark theme, download and get cdn button.

Thank you, @I-VipulPandey, for your reply. Could you please share a prototype or design sample illustrating the changes you intend to contribute? This will help us better understand the modifications you wish to make to the repository.

The current design of nav bar doesn't give user all the details, thus by adding icons on nav bar and displaying them when hovered user can get more details what function will the following button will do. I am attaching a video of what I exactly ment, I can also change it if you have something specific.

My.Video.mp4

@I-VipulPandey please go forward with it. Please pull the latest changes

priyanka7976 commented 1 year ago

I am GSSoc contrbutor. I would like to work on the issue pls assign it to me.

AshutoshDash1999 commented 1 year ago

@I-VipulPandey have you submitted a PR for this?

pjyoti121 commented 1 year ago

please assign me this issue

AshutoshDash1999 commented 1 year ago

@pjyoti121 assigning this to you

AshutoshDash1999 commented 1 year ago

@pjyoti121 please update on this issue

Kajal2468 commented 1 year ago

please assign this issue .

AshutoshDash1999 commented 1 year ago

@Kajal2468 assigning this issue to you

Kajal2468 commented 1 year ago

Thank You sir for assign this project , It's my pleaser to work on this project .

AshutoshDash1999 commented 1 year ago

@Kajal2468 what's the update on this?

Kajal2468 commented 1 year ago

@AshutoshDash1999 still Working on this project.

Kajal2468 commented 1 year ago

@AshutoshDash1999 in navbar section which type of icons u want to take can u share some sample this will help me to better understand the modification because in navbar already dark light / download / Repo section available..... navbar

Thank You!!

AshutoshDash1999 commented 1 year ago

use the icons like that in Repo button

Kajal2468 commented 1 year ago

ok