Bookingjini-Tech / bookingjini-icons-archive

Find hospitality related icons, curated by creators from Bookingjini
https://icons.bookingjini.tech
MIT License
44 stars 116 forks source link

modify the navbar #469

Closed parasss19 closed 1 year ago

parasss19 commented 1 year ago

Closed issue #463

Description

Screenshot

https://github.com/Bookingjini-Labs/bookingjini-icons/assets/101205226/7a50448b-9ce4-46aa-95ec-877fe83241b3

netlify[bot] commented 1 year ago

Deploy Preview for visionary-baklava-12513a ready!

Name Link
Latest commit 5d547528c0083d659c86f779a62055b0bb914221
Latest deploy log https://app.netlify.com/sites/visionary-baklava-12513a/deploys/64cc8f659962a900084ba06e
Deploy Preview https://deploy-preview-469--visionary-baklava-12513a.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

parasss19 commented 1 year ago

Hey @AshutoshDash1999 Please review it

AshutoshDash1999 commented 1 year ago

why have you added styling inline when there is separate file for CSS?

parasss19 commented 1 year ago
  • remove the border
  • decrease the padding in y-axis
  • increase the blur

why have you added styling inline when there is separate file for CSS?

Actually the css is not working when i write in separate css file

AshutoshDash1999 commented 1 year ago

Actually the css is not working when i write in separate css file

that means another CSS is overriding it. Please debug that

parasss19 commented 1 year ago

Actually the css is not working when i write in separate css file

that means another CSS is overriding it. Please debug that

actually your are using cdn files thats why its happening and i dont know much about that so cant help in debug

AshutoshDash1999 commented 1 year ago

I can't accept the PR unless its good enough to be accepted.

parasss19 commented 1 year ago

I can't accept the PR unless its good enough to be accepted.

I am busy assigned someone else