davidfarmer
commented
10 years ago I thought it was a cool idea, but I am agreeable to remove it, especially since we have the buttons.
On Fri, 15 Aug 2014, Michael DuBois wrote:
I debated this a bit when I first set out. I didn't like the complexity that it added, but I thought I'd try it out to see if we could do one better than other sites.
As it happens, there are a number of reasons we might consider dropping the feature:
- The touch events don't work currently. I opted to break it in favor of quickly restoring one-finger scrolling on iPads.
- We can still animate the sidebar opening and closing when the user taps the menu button by adding a class with jQuery and setting CSS transition properties on the sidebar-left-open and sidebar-right-open classes.
- Coordinating touch events with the animation adds complexity. I would not need the 3 scripts for the GSAP animation library nor SidebarView.js nor TouchController.js if we didn't need fine-grained control of the sidebar animation to match it up to the touch position during swipe open/close events. It would then be simpler to animate changes elsewhere on the page relating to the sidebars opening/closing since we would not need to use GSAP for the animation. In a web app, with an in-house team of maintainers, I wouldn't be concerned about this complexity, but you guys probably want to keep things light and simple.
- It seems like javascript touch event handling is a little slower than native touch events in mobile apps, so it never felt smooth enough to me when it was working.
- It may conflict with some browser controls
- On my phone, swiping out from the edge of the screen opens a browser menu for opening new tabs.
- In Safari on iOS7, it seems like swiping from the edge of the screen can be used for browser back/forward?
- Most people will probably click the menu button anyway.
- While it's common in mobile apps, it's uncommon on websites, perhaps because of all the above.
So, it was a fun experiment, but I think I'd recommend removing it.
Removing the feature is very easy. It would require minimal changes to the CSS and javascript.
— Reply to this email directly or view it onGitHub.[211500__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyMzc2MzUwNCwiZGF0YSI6eyJpZCI6Mzk4MzEwMTN9fQ==--61c3b25d84f580e220374a9943de156a00 cb43c2.gif]
rbeezer
mxdubois
I debated this a bit when I first set out. I didn't like the complexity that it added, but I thought I'd try it out to see if we could do one better than other sites.
As it happens, there are a number of reasons we might consider dropping the feature:
sidebar-left-openandsidebar-right-openclasses.SidebarView.jsnorTouchController.jsif we didn't need fine-grained control of the sidebar animation to match it up to the touch position during swipe open/close events. It would then be simpler to animate changes elsewhere on the page relating to the sidebars opening/closing since we would not need to use GSAP for the animation. In a web app, with an in-house team of maintainers, I wouldn't be concerned about this complexity, but you guys probably want to keep things light and simple.So, it was a fun experiment, but I think I'd recommend removing it.
Removing the feature is very easy. It would require minimal changes to the CSS and javascript.