search

BooksHTML / mathbook-assets

Styles and scripts for the Mathbook platform.
0 stars 3 forks source link

Disable clickability of Contents header of sidebar #61

Closed rbeezer closed 7 years ago

rbeezer commented 9 years ago

Once upon a time clicking this did something, but we backed out on that. Now it appears clickable (cursor change on hover), but nothing happens (confusing users).

rbeezer commented 9 years ago

Maybe there just needs to be a minor change in the HTML output that looks like: <button class="sidebar-left-toggle-button button active"> rather than editing the CSS itself.

rbeezer commented 9 years ago

Dropping the "active" in two places (my HTML converter) with a "sidebar-left-toggle-button" had no visual effect. Nor replacing "active" by "inactive".

So I think this needs work here, as part of how the CSS behaves.

davidfarmer commented 9 years ago

It is inside something called a "button", so it acts like a button.

That makes sense, but it isn't what we want.

I'll (eventually) look into how to only change the CSS. If the HTML has to change, then that should wait until we also have to make other markup changes.

On Fri, 6 Feb 2015, Rob Beezer wrote:

Dropping the "active" in two places (my HTML converter) with a "sidebar-left-toggle-button" had no visual effect. Nor replacing "active" by "inactive".

So I think this needs work here, as part of how the CSS behaves.

— Reply to this email directly or view it on GitHub.[AAM6LATHObkALnPQiKMrm1Y0zJTS4k_uks5npX5lgaJpZM4DaFs2.gif]

rbeezer commented 9 years ago

Thanks, that does make sense. No rush.

On 02/09/2015 05:45 AM, davidfarmer wrote:

It is inside something called a "button", so it acts like a button.

That makes sense, but it isn't what we want.

I'll (eventually) look into how to only change the CSS. If the HTML has to change, then that should wait until we also have to make other markup changes.

On Fri, 6 Feb 2015, Rob Beezer wrote:

Dropping the "active" in two places (my HTML converter) with a "sidebar-left-toggle-button" had no visual effect. Nor replacing "active" by "inactive".

So I think this needs work here, as part of how the CSS behaves.

— Reply to this email directly or view it on GitHub.[AAM6LATHObkALnPQiKMrm1Y0zJTS4k_uks5npX5lgaJpZM4DaFs2.gif]

— Reply to this email directly or view it on GitHub https://github.com/BooksHTML/mathbook-assets/issues/61#issuecomment-73510195.

davidfarmer commented 7 years ago

Closing, because now the button hides the TOC. That has its own separate issues.