search

BoolNordicAB / sharepoint-utilities

Makes client side SharePoint a bit nicer to work with (that's the plan, at least)
https://boolnordicab.github.io/sharepoint-utilities/doc/index.html
MIT License
14 stars 3 forks source link

ReferenceError fjs #36

Closed mirontoli closed 8 years ago

mirontoli commented 8 years ago

A really good utiltiy framework. I can build it, but when I run tests, I get this error:

PhantomJS 1.9.8 (Mac OS X 0.0.0) ERROR ReferenceError: Can't find variable: fjs

image

Just for information, I installed these three npm packages (because the were missing): npm install mocha chai fjs

The error is on line 29 in the file sputils.list.files.js

sputils.list = fjs.assign(sputils.list || {},

@eakron @roobie

roobie commented 8 years ago

I'll check it out. Also, in order for this to never happen again, I'll add husky and a prepush hook that runs the tests, so that this kind of silly errors are caught before being pushed to the repo.

roobie commented 8 years ago

I could reproduce this prior to running bower install. After installing the bower components, the error disappeared, so I'm guessing that is the cause. I'll add a pretest clause in package.json, which will mitigate this.

mirontoli commented 8 years ago

Thank you! Nice.