search

Boolector / boolector

A Satisfiability Modulo Theories (SMT) solver for the theories of fixed-size bit-vectors, arrays and uninterpreted functions.
http://boolector.github.io
Other
335 stars 62 forks source link

contrib/setup-utils.sh: Recognize 64-bit MinGW #181

Closed RyanGlScott closed 2 years ago

RyanGlScott commented 2 years ago

On 64-bit versions of MinGW, uname -s will output:

$ uname -s
MINGW64_NT-10.0-19044

This trips up the is_windows function in contrib/setup-utils.sh, however, as it only checks for MINGW32*, not MINGW64*. As a result, trying to build boolector with 64-bit MinGW will fail since the proper Windows-specific patches are not applied.

This provides a simple fix of checking both MINGW32* and MINGW64*.

RyanGlScott commented 2 years ago

This issue also appears to exist in Bitwuzla (see here). Let me know if I should open a PR to Bitwuzla as well.

mpreiner commented 2 years ago

Hi @RyanGlScott,

Thanks for the fix! Can you please sign the commit as documented here: https://github.com/boolector/boolector#contributing

We'd welcome a fix for Bitwuzla too.

Thanks, Mathias

RyanGlScott commented 2 years ago

Ah, thanks for the pointer. I've amended my commit with a sign-off.

RyanGlScott commented 2 years ago

I've also submitted a corresponding PR at bitwuzla/bitwuzla#18.