Closed aytey closed 4 years ago
@mpreiner thanks for the comments -- all done.
There are two changes since you last reviewed this:
The Dockerfile used to git clone
Boolector into itself -- this wasn't ideal, as it meant you couldn't build your own local branch inside of Docker, only the current master. This is now changed the Dockerfile copies the current repository into itself before building (which means you can build your own local branches). The documentation has slightly changed to reflect this modified build step.
I rebased this branch on top of my the latest Windows patches branches -- without these updates, you couldn't build CaDiCaL inside of Docker. I have not squashed this commit. If the Windows patches go into master first, I can then rebase this onto of master and /voila/.
@andrewvaughanj @mpreiner what is the status of this one?
Fix for Issue #33.
Tested as working, and passing the tests, with the latest CaDiCaL.