contrib: fix scripts - Githubissues

Boolector / boolector

A Satisfiability Modulo Theories (SMT) solver for the theories of fixed-size bit-vectors, arrays and uninterpreted functions.

http://boolector.github.io

Other

332 stars 62 forks source link

Closed q3k closed 5 years ago

q3k commented 5 years ago

The contrib/setup-* scripts are currently broken in the following two ways:

hardcoded /bin/bash interpreter path, which is not true on all systems (BSDs, and non-FHS Linux distributions like NixOS)
no -e -o pipefail, causing any failures within the contrib build machinery to fail silently instead of bubbling up to the caller

This change addresses the above issues.

mpreiner commented 5 years ago

Ah nice! Didn't know about -o pipefail. Thanks a lot! PicoSAT setup already fails on MacOS. I'll fix that on master and update this PR.