Add CI for a Python wheel release to PyPi

[mballance]

Signed-off-by: Matthew Ballance matt.ballance@gmail.com

[mballance]

I've updated the Azure Pipelines specification to only authenticate and upload to PyPi when the build is done from the 'master' branch. It's pretty unlikely that we want PR builds to make uploads to PyPi.

In order to enable automated uploads to pypi.org, the following must be done in the Azure Pipelines Builds section. Before doing so, register for a free account on pypi.org

• Project Settings -> Service Connections (it's under the Pipelines heading)
• New Service connection -> Python package upload
  • Connection name: pypi
  • Python repository url for upload: https://pypi.python.org/pypi
  • EndpointName: pyboolector
  • Username: pypi.org username
  • Password: pypi.org password
• Select OK

The CI script can now authenticate a connection to PyPi.org via the information saved in the service connection configuration.

[mpreiner]

@mballance Thanks a lot for the work and sorry for the delay! We'll have a look and setup pypi ASAP.

[mpreiner]

@mballance Sorry that this takes so long. I had a brief look (will dive into it more soon). However, I have one question: Why did you choose to use Apache instead of sticking with MIT that comes with Boolector? This may cause some confusion since only the code for packaging pyboolector for pypi would be under Apache, but Boolector and pyboolector are still MIT, which is currently not reflected in setup.py.

[mballance]

@mpreiner, looks like an oversight on my part. I'll be happy to correct the license to align with the MIT that Boolector uses.

-Matthew

[mpreiner]

Thanks @mballance!

[mballance]

Hi @mpreiner, I've updated the PR with your requested changes, and also added in a couple of changes from the separate CI build -- macOS release, and improved versioning.

• The PR now uses the contrib/setup scripts for building dependencies. I updated the lingeling commit hash to pick up the fix for a name-collision bug (https://github.com/arminbiere/lingeling/pull/2) that impacted the PyPi builds
• Both CaDiCaL and Lingeling SAT solvers are provided
• Simplified the build script for Linux, and made a few updates to Docker image and CI config

Thanks and Best Regards, Matthew

[aytey]

My Lingeling PR isn’t merged; how are you using the commit hash from that?

Could we do something here like we do with the Windows patches to make this self-contained within the Boolector repo?

[mballance]

My Lingeling PR isn’t merged; how are you using the commit hash from that?

Could we do something here like we do with the Windows patches to make this self-contained within the Boolector repo?

Apologies for the confusion, @andrewvaughanj. I wanted to point @mpreiner to a description of the issue resolved by moving to the latest lingeling code. It appears the issue has been resolved independent of your PR. The clone variable is now named 'cloned'.

[aytey]

My Lingeling PR isn’t merged; how are you using the commit hash from that? Could we do something here like we do with the Windows patches to make this self-contained within the Boolector repo?

Apologies for the confusion, @andrewvaughanj. I wanted to point @mpreiner to a description of the issue resolved by moving to the latest lingeling code. It appears the issue has been resolved independent of your PR. The clone variable is now named 'cloned'.

Ah! All good :)

[mballance]

@mballance is there anything else to do other than what you wrote here once the PR is merged?

@mpreiner, other than configuring PyPi upload (referenced link), we should be good to go. Please let me know the PyPi username that will be doing uploads, since I think I'll need to add it to the PyPi project.