Booligoosh / rubiks-time

A clean, modern Rubik's cube timer
https://booligoosh.github.io/rubiks-time/
3 stars 0 forks source link

Remove extra lines when too less solves are done #3

Open YTCuber opened 7 years ago

YTCuber commented 7 years ago

If no average of 5/12 can be done because of too less solve, the <hr>s are still there and look bad. I would suggest do display only 1 <hr> at the bottom.

This is how your code looks in the browser with 0 solves:

<div id="screen6" style="display: block;">
    <!-- Some more unimportant code -->
      <hr>
      <h2 id="average">Average - NaN:NaN.NaN</h2>
      <hr>
      <h2 id="currentaverageof5"></h2>
      <hr>
      <h2 id="bestaverageof5"></h2>
      <hr>
      <h2 id="currentaverageof12"></h2>
      <hr>
      <h2 id="bestaverageof12"></h2>
    </div>

and these are the visible elements:

<div id="screen6" style="display: block;">
    <!-- ... -->
      <hr>
      <h2 id="average">Average - NaN:NaN.NaN</h2>
      <hr>
      <hr>
      <hr>
      <hr>
    </div>