Boomaa23 / open-ds

A reverse-engineered lightweight cross-platform FRC Driver Station
https://boomaa23.github.io/open-ds/
Other
42 stars 8 forks source link

Save some state between runs #13

Closed jmorris-frc2016 closed 2 years ago

jmorris-frc2016 commented 2 years ago

Maybe I'm doing something wrong, but seems everytime I start the program I have to input my team number, is it possible to have it save that state?

Boomaa23 commented 2 years ago

Hi, that is the intended function of the program but I can add that feature when I get a chance.

Boomaa23 commented 2 years ago

@jmorris-frc2016 this feature should be implemented as of fde61e993c220e303c71a9c3b1da37bb4aaad7e1. Please let me know if you have any issues. Closing this issue as the feature has been implemented.

jmorris-frc2016 commented 2 years ago

Hey thanks for your quick responses on both of these! how do i get an updated jar file?

Boomaa23 commented 2 years ago

I'll publish another jar file next release, otherwise you can build from the source code.

jmorris-frc2016 commented 2 years ago

Hey Boomaa, I built and run the latest code but noticed it only persists between launches as long as the machine isnt powered off. (as in every cold boot requires you to type in your team number)

Boomaa23 commented 2 years ago

The persistent team number is written to your computer's temp directory, so this would indicate that your temp directory is being cleared on restart. I don't want to put the persistent file anywhere else since OpenDS doesn't really have a "home" directory. Regardless, this folder shouldn't be cleared by restart. Unfortunately I can't reproduce this error so I can't really help here.

jmorris-frc2016 commented 2 years ago

Thanks for getting back to me, I'm using a lightweight Linux distro (Q4OS) so it could definitely be on my end. If I wanted to modify it to take a couple things as command line parameters, is there a file that acts as an entrypoint?

On Sat, Jun 25, 2022, 9:38 PM Boomaa23 @.***> wrote:

The persistent team number is written to your computer's temp directory, so this would indicate that your temp directory is being cleared on restart. I don't want to put the persistent file anywhere else since OpenDS doesn't really have a "home" directory. Regardless, this folder shouldn't be cleared by restart. Unfortunately I can't reproduce this error so I can't really help here.

— Reply to this email directly, view it on GitHub https://github.com/Boomaa23/open-ds/issues/13#issuecomment-1166393617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYSMKGD2JRWNQZZH7IT7P4TVQ6YC3ANCNFSM5YY2BUPQ . You are receiving this because you were mentioned.Message ID: @.***>

NoahAndrews commented 2 years ago

Regardless, this folder shouldn't be cleared by restart.

Why not, that's what I would expect. "Temporary" means that it won't last forever, so anything there should be safe to delete as long as it's not actively being used by a program, and a reboot is the safest time to clean up that data.

Boomaa23 commented 2 years ago

Temporary generally doesn't mean that it'll be systematically reset, you can assume there will be some persistence there generally even if there is volatility in that. I think CLI parameters are a good idea, but I'd like to include more than just this if I was to have some CLI params. I will work on it.

jmorris-frc2016 commented 2 years ago

Yea, for command line arguments I'd love to have fms, usb, and team number.

Boomaa23 commented 2 years ago

Alright I've written something that should work, as of 9d75ddbb85b2106e2109d5ad2f8603cdbb998bb6. Use --tpf [fileloc] to specify the team number persist file (just a text file with a number in it) or --team-num [number] to directly set the team number. Let me know if you have issues.

jmorris-frc2016 commented 2 years ago

the command line arguments work great! im just using the --team-num version, but having both seems like a good idea, thanks Boomaa