Fixed issue #146: DOS MZ Exe misidentified as NE Exe

BoomerangDecompiler / boomerang

Boomerang Decompiler - Fighting the code-rot :)

Other

374 stars 59 forks source link

Fixed issue #146: DOS MZ Exe misidentified as NE Exe #147

Closed powerbf closed 5 years ago

powerbf commented 5 years ago

Look for NE header instead of relying on reloc table offset which can throw up a false positive

ceeac commented 5 years ago

I think it is better to directly reject NE executables in ExeBinaryLoader::canLoad, to give other plugins a chance to read the file. I will do a more detailed review tomorrow.

powerbf commented 5 years ago

Agreed. This check should be in canLoad(). I've moved it.

powerbf commented 5 years ago

Replaced by pull request #150