search

BoomerangDecompiler / boomerang

Boomerang Decompiler - Fighting the code-rot :)
Other
374 stars 59 forks source link

QMap::unite deprecated and removed #269

Closed greg-szabo closed 3 years ago

greg-szabo commented 4 years ago

OS: MacOS Mojave 10.14.6

Boomerang version or git hash: boomerang-cli v0.5.2-366-g1944b804e

Steps to reproduce:

  1. Run the MacOS installation steps.

Expected behaviour/output: The application builds.

Actual behaviour/output: You will get an error message during the build process:

/boomerang/src/boomerang/db/binary/BinarySection.cpp:26:19: error: 'unite' is deprecated: Use QMultiMap for maps storing multiple values with the same key.
      [-Werror,-Wdeprecated-declarations]
        val = val.unite(other.val);
                  ^

(The message is in line 26 and line 91 in the same file.)

Additional comments: Apparently, HomeBrew upgraded to a Qt version (5.15.1) that removed the unite method from QMap. It has been deprecated for a while, so that's expected.