search

Boonda-P / gource

Automatically exported from code.google.com/p/gource
0 stars 0 forks source link

--max-file-lag depends on fps #30

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I've set --max-file-lag 0.001, but it looks like the minimum delay between 
two files is limited to the current frame time.

It's makes the video very long for huge commits (1k-100k files) that are 
expected to take seconds, not minutes, even if fps is low.

Original issue reported on code.google.com by buryak.a...@gmail.com on 12 Jan 2010 at 8:17

GoogleCodeExporter commented 8 years ago 
If your able to provide a log as an example I'd be curious too what's happening,
though it might be hard to fix.

It does seem kind of an extreme edge case.

Original comment by acaudw...@gmail.com on 12 Jan 2010 at 10:01

GoogleCodeExporter commented 8 years ago 
I've attached sample log. Run it with "gource --max-file-lag 0.001 log.txt"
Log has one commit with 1500 files added and as I understand --max-file-lag 
option, it 
should take ~1.5sec, but it takes much longer...

Original comment by buryak.a...@gmail.com on 12 Jan 2010 at 10:08

Attachments:

GoogleCodeExporter commented 8 years ago 
I think the number of log records read is frame rate based, and the custom log 
format
has only one file per record, so it's going to take 25 seconds at 60fps to add 
1500
files.

I guess a work around would be some sort of --max-records-per-frame option.

Original comment by acaudw...@gmail.com on 12 Jan 2010 at 10:33

GoogleCodeExporter commented 8 years ago 
In my opinion it's better to completely remove frame rate dependency instead of 
making 
strange options that depend on user hardware and OS.

Original comment by buryak.a...@gmail.com on 12 Jan 2010 at 10:38

GoogleCodeExporter commented 8 years ago 
I've changed it so now a contiguous block of records in the custom log with the 
same
username and timestamp are considered the same commit, so max-file-lag will 
work:

http://gource.googlecode.com/files/gource-0.24-beta2.tar.gz

Original comment by acaudw...@gmail.com on 31 Jan 2010 at 10:35

GoogleCodeExporter commented 8 years ago 
Thanks a lot! I'll wait for official release since I'm using windows-build of 
Gource.

Original comment by buryak.a...@gmail.com on 1 Feb 2010 at 5:23

GoogleCodeExporter commented 8 years ago 
And here it is:
http://gource.googlecode.com/files/gource-0.24.win32.zip

Original comment by acaudw...@gmail.com on 2 Feb 2010 at 9:40

GoogleCodeExporter commented 8 years ago 
Works great, thank you!

Original comment by buryak.a...@gmail.com on 2 Feb 2010 at 8:13