search

BoostGSoC20 / ublas

Boost.uBlas
https://www.boost.org/doc/libs/release/libs/numeric/ublas
1 stars 2 forks source link

Clang tidy review check #10

Closed coder3101 closed 4 years ago

coder3101 commented 4 years ago

This is a review check PR. SHOULD NOT BE MERGED

Here is what should happen by automated review CI:

For the test purpose, I formatted the tensor.hpp file and am proposing as PR now

The review bot should come and put a clang-tidy review for that file changes. 🤞 (crossed fingers)

coder3101 commented 4 years ago

Now, I will sync the PR, simulating a change and see if bot again spams or not.

coder3101 commented 4 years ago

As you can see the bot is not spamming by commenting the same thing again and again.

I will now change a few lines of tensor.hpp so that new lines are also affected and for new lines updated in the source, the bot should again review and put only the new warnings, keeping the old warnings intact and without repeating.

coder3101 commented 4 years ago

The review fails if some compilation error occurs. As in this case!

coder3101 commented 4 years ago

Okay, now the compilation error has been fixed. Let me create a new member function rend2() and the CI should report that the trailing return type should be used [modernize-use-trailing-return-type]. 🤞

coder3101 commented 4 years ago

Okay finalized. Everything is working as expected.

@bassoy you can review this PR for what exactly a automated review by CI will look like!

coder3101 commented 4 years ago

The types of check to run is defined by this file named .clang-tidy in the root of ublas.

coder3101 commented 4 years ago

For your review and technical details as to how it is performed, here are the files that you should be looking into:

coder3101 commented 4 years ago

Closed in favor of #14