search

BoostGSoC21 / math

Boost.org math module
http://boost.org/libs/math
Boost Software License 1.0
0 stars 1 forks source link

Try adding more CI tests in MSVC #26

Closed cosurgi closed 3 years ago

cosurgi commented 3 years ago

@ckormanyos this branch fft_janek is rebased on fft_chris so I have your latest stuff.

But it is not rebased on 1_over_N, I am not sure if @Lagrang3 will add more stuff there.

It is just a note so that we don't miss any commits.

cosurgi commented 3 years ago

Oops, we now have this error:

fft_correctedness.cpp(73): fatal error C1001: An internal error has occurred in the compiler.
(compiler file 'msc1.cpp', line 1468)
ckormanyos commented 3 years ago

we now have this error:

fft_correctedness.cpp(73): fatal error C1001: An internal error

That is a tough one. The compiler's lexical parser crashed internally, itself, with no diagnostics whatsoever. The code is probably fine.

Unfortunately, it's on 14.0 (which i do not have set up at the moment). I have seen this kind of thing a lot, however, so I'll take a look.

Basically, I see if I can determine if it's in header or cpp. Then I do a binary search via #if 0/#endif sectioning within the offending file itself to narrow down the offending lines themselves (or what makes the compiler crash internally).

After all that... We re-write the lines that the legacy compiler can't deal with.

This must be done because msvc 14.0 is mandatory for us. i will dive into it.

Cc: @cosurgi and @Lagrang3

cosurgi commented 3 years ago

@ckormanyos To avoid a third PR please feel free to push to my branch in this PR. I am routinely git pulling on my end.

ckormanyos commented 3 years ago

Hi @cosurgi

Yes, please feel free to simply comment out the file that causes fatal error C1001. There is literally zero development content in dealing with that --- less than zero actually. If anyone spends time on it, I'll do it within the context of my administrative duties in the project.

Full speed ahead on the actual development...

cosurgi commented 3 years ago

Yes, thank you for having a look at these small changes.

cosurgi commented 3 years ago

@Lagrang3 should fft_ex06.cpp work the same when replacing fftw_rfft with gsl_rfft or bsl_rfft? It could be used for msvc tests then.

ckormanyos commented 3 years ago

Hi @cosurgi and @Lagrang3 I would like to get these added CI files for msvc into develop of the fork.

May I merge to develop of the fork?

Lagrang3 commented 3 years ago

@Lagrang3 should fft_ex06.cpp work the same when replacing fftw_rfft with gsl_rfft or bsl_rfft? It could be used for msvc tests then.

@cosurgi yes.

Lagrang3 commented 3 years ago

Hi @cosurgi and @Lagrang3 I would like to get these added CI files for msvc into develop of the fork.

May I merge to develop of the fork?

To me yes.

ckormanyos commented 3 years ago

There are a few trivial warnings in CI on msvc that I will deal with (when also trying to deal with misc 1001 crash).

For now, we get these tests into develop. CI is cycling. Looks good...

cosurgi commented 3 years ago

For now, we get these tests into develop. CI is cycling. Looks good...

This is great. We are steadily moving forward.

@Lagrang3 should fft_ex06.cpp work the same when replacing fftw_rfft with gsl_rfft or bsl_rfft? It could be used for msvc tests then.

@cosurgi yes.

OK, let's try that in next PR.