search

BoostIO / BoostNote-App

Boost Note is a document driven project management tool that maximizes remote DevOps team velocity.
https://boostnote.io
Other
3.78k stars 371 forks source link

Improve URL select for URL prop #1542

Closed Komediruzecki closed 2 years ago

Komediruzecki commented 2 years ago

Add open selector when URL is empty or invalid

Showcase:

https://user-images.githubusercontent.com/18196945/159187026-3aa25154-2238-45ad-88ab-5c00b6221f4e.mp4

Komediruzecki commented 2 years ago

Let's change a bit more. For the url, users need to click the url text to navigate.

Screen Shot 2022-03-28 at 4 56 02 PM

Users should click the red area to navigate to the url. If users click other than this area, including padding and the pencil icon, edit mode should be activated.

Yes, thought about it as well, will do.

Komediruzecki commented 2 years ago

Let's change a bit more. For the url, users need to click the url text to navigate.

Screen Shot 2022-03-28 at 4 56 02 PM

Users should click the red area to navigate to the url. If users click other than this area, including padding and the pencil icon, edit mode should be activated.

Yes, thought about it as well, will do.

@Rokt33r Added the change, its a bit of a hack since the property button is the parent of this element, so it's not easy to make it clickable to edit but also prevent opening URL, and otherwise impossible to put it outside of the property button, but preventing the clicking of URL.

So I've put it absolutely positioned on top, seems to be working nicely.

I've noticed that the link is being opened twice actually (not sure why), and if it's a known issue, it happens on Ubuntu.