BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App

Other

17.07k stars 1.47k forks source link

testing 0.11.9-pre.1 #2316

Closed ghost closed 6 years ago

ghost commented 6 years ago

hello, I just installed the latest pre-release for testing and I am experiencing some problems.

it is significantly slower now taking almost 2 seconds to display a note
task lists are no longer working in full view
toggle mode is not working when clicking into the text body (I did not lock the view)

Environment

Version : 0.11.9-pre.1
OS Version and name : 16.04 Ubuntu

Rokt33r commented 6 years ago

it is significantly slower now taking almost 2 seconds to display a note

It seems to be slow when opening snippet note.

Rokt33r commented 6 years ago

@ZeroX-DG Could you help me?

ZeroX-DG commented 6 years ago

Yes, I'm working on it

ZeroX-DG commented 6 years ago

Note:

The first bug occurred due to the library: https://github.com/podefr/react-debounce-render used in the PR: https://github.com/BoostIO/Boostnote/pull/2074. I haven't found this exact why that library is the cause but by removing it, the first bug disappeared.
The second bug occurred due to that same library in the first bug. That library create a higher component so we can't access the function in the original component. The bad news is that library doesn't create an easy way to access the original component so we have to dig deep into the returned component to access the original which make the code....you get the point.
The third bug has the same cause as the second bug

ghost commented 6 years ago

@ZeroX-DG

In 0.11.8 you were able to enter editor view by left-clicking into the note:

before

In 0.11.9-pre.1 this feature is no longer supported, if I click on it, nothing happens:

after

ZeroX-DG commented 6 years ago

Oh then I the 3rd issue has the same cause as the 2nd issue.

sosukesuzuki commented 6 years ago

Note:

1st issue:
- react-debounce-render causes delay in a note display. I use it to improve the delay in displaying notes. However, I think that we should revert to not use this library to fix bugs. (The reversing should not cause fatal problems.)
2nd & 3rd issues
- Thees seems to be caused by react-debounce-render. However, I can not find out why yet currently...:bow:
- (Viewed from Elements of the developer tool, the style of CodeEditor and MarkdownPreview seems to be strange)

ZeroX-DG commented 6 years ago

@sosukesuzuki The 2nd & 3rd issues is caused by react-debounce-render as the library create a higher order component and wrap the original component (code). Therefore, in some other component, they can't access the original component (MarkdownEditor) method such as reload

Rokt33r commented 6 years ago

I've reverted the previous PR, https://github.com/BoostIO/Boostnote/pull/2074/files And, it seems to fix the bugs. I'll release v0.11.9-pre.2 tonight.

You can check it from the master branch too. I've already merged the fix.

Thank you all guys!! ❤️