BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.07k stars 1.47k forks source link

PlantUML text colors unreadable on dark backgrounds #2559

Open Redsandro opened 5 years ago

Redsandro commented 5 years ago

Current behavior

Choosing a dark theme is popular. These are the most common reasons for choosing a dark theme:

Boostnote was very aware of this, and you can choose a dark theme:

image

The problem is that PlantUML, which has black borders and black text, now becomes unreadable:

image

Expected behavior

Colors are automatically adjusted to a more fitting and contrasting palette for dark themes.

Steps to reproduce

  1. Select a dark theme.
  2. Enter some PlantUML in a note.

Environment

IssueHuntBot commented 5 years ago

@boostio funded this issue with $10. See it on IssueHunt

simosdev commented 5 years ago

I realize this is not a real fix for this, but for time being you can use plantuml skinparam to change the background to be able to read the text. It seems Boostnote makes white background transparent which causes issues with dark themes.

You can use skinparam backgroundColor #FFFFFE or similar to get almost white background. Another quick one if you need something more dark is skinparam monochrome reverse.

You could probably define custom colors for all the elements, but the definitions depends on type a diagram, so not really feasible to do that manually everytime (you could copy-paste though). Probably the real implementation to fix this would define hidden defaults for each Boostnote interface theme, but still allow user customization with skinparam if needed.

Lythenas commented 5 years ago

I had the same issue when embedding svgs. Black text (or lines) are not readable in dark themes.

As a fix I added

img {
  background-color: #fff;
}

to the custom css setting.

That also worked for plantuml diagrams because they are just pngs with transparent background.

pradeepgangwar commented 4 years ago

Is this issue still open to solve? @Redsandro

Flexo013 commented 4 years ago

@pradeepgangwar You can try this with the latest version (0.13.0) and check the current behavior. If the behavior is still the same, then yes the issue is still open to solve. If the behavior is already different/fixed, then you can comment here so we can close this issue.

MiloTodt commented 4 years ago

As a temporary measure, if you'd like you can add

skinparam monochrome reverse
skinparam backgroundColor transparent

inside of your UML diagram.

Screenshot from 2019-12-11 02-41-42