BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.08k stars 1.47k forks source link

Allow optional arguments for Ditaa #2833

Open Skovisen opened 5 years ago

Skovisen commented 5 years ago

According to the plantUML documentation regarding inline Ditaa you should be able to specify optional arguments, either as

Option 1:

@startditaa arguments-given-here
...
@endditaa

or as

Option 2:

@startuml
ditaa(arguments-given-here)
...
@enduml

Expected Behavior

The following code with Option 1:

@startditaa  --no-separation
+-------+
|+------++
||+------++
|||       |
++|       |
 ++       |
  +-------+
@endditaa

or Option 2:

@startuml
ditaa(--no-separation)
+-------+
|+------++
||+------++
|||       |
++|       |
 ++       |
  +-------+
@enduml

should both give test

Current behavior

Option 1 gives: test_2

Option 2 gives: uml-diagram

According to the developer tools, there seems to be a bad request towards some plantuml server whenever option 2 is used. Note that it seems that option 2 doesn't work at all, not even without options.

Steps to reproduce

  1. Open a new Markdown note
  2. Copy-paste code given above into editor
  3. Observe how it renders

Environment

Flexo013 commented 4 years ago

Bumping this as it would be a nice feature.