BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.07k stars 1.47k forks source link

Warn when storage becomes unavailable #3073

Open jsosulski opened 5 years ago

jsosulski commented 5 years ago

Current behavior

Similar to https://github.com/BoostIO/Boostnote/issues/3072, but with a running instance of BoostNote.

When a storage location becomes unavailable while BoostNote is running, the user does not receive any notification whatsoever.

  1. Your are able to edit notes, however, changes will not be saved to disk!

image

  1. BoostNote does nothing when trying to create a new note.

image

Expected behavior

  1. A popup or some status icon warns the user that changes to notes are not stored to disk.
  2. A notitification that tells you why creation of the note failed.

Steps to reproduce

  1. Create storage location on removable media, add a folder and some random note.
  2. Remove media while BoostNote is running.
  3. Try to edit a note in said storage location / try to create a new note in said storage location.

Environment

rvbcldud commented 5 years ago

Relatively new to contributing to open source but I believe I have an improvement to the current scenario Any input would be greatly appreciated :)

Code Added

window.alert('Boostnote disk not found, try reconnecting disk')

Screenshots

2 Cases

  1. When adding to disconnected boostnote directory boostnotefix
  2. When attempting to create a new note boostnotefix2