search

BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.07k stars 1.47k forks source link

Grave accent matching character does not work on Swedish keyboard layout #3299

Open Menturan opened 4 years ago

Menturan commented 4 years ago

Current behavior

When typing the grave accent character, it doesn't autocomplete with matching or triples.

grave_accent_boostnote

Expected behavior

Autocomplete with matching or triples grave accent characters.

Steps to reproduce

  1. Choose Swedish as your keyboard layout
  2. Make a grave accent by pressing Shift+key-to-the-left-of-backspace (plus-key on us keyboards) twice for completion with matching and or four times for completion with triples.

Theory

My theory why this doesn't work is that the grave-accent-key is on another key than on us keyboards and you have to press Shift+grave-accent-key.

Environment

Flexo013 commented 4 years ago

I have the feeling that the code might be looking for the grave/backtick keypress, rather than looking at what the last character typed was. So when different keyboard layouts actually have the character somewhere else it doesn't trigger.

arcturus140 commented 4 years ago

[[Shift-L]] === [[Shift-R]]

swedish

I have the feeling that the code might be looking for the grave/backtick keypress, rather than looking at what the last character typed was.

without looking at the code I would expect the input be abstract to auto completion.

Environment

Flexo013 commented 4 years ago

@arcturus140 Could you check this with 0.13.0 as well? Just to make sure nothing affected this behavior between 0.11.12 and now.

Menturan commented 4 years ago

I notice that Boostnote uses Codemirror as text editor and that there is an closebrackets.js addon that we are using for this functionality. Maybe the issue is with that addon?

arcturus140 commented 4 years ago

@Flexo013 I repeated the test, same result. FYI I am using a different keyboard but similar layout myself and never had any issues. Is there a way to log input keys in Boostnote?

Maybe system region settings make a difference?

@Menturan are you using swedish in swedish or a subtype variant, like DVORAK or Macintosh?

Do you get the same result when using

What is your Editor Keymap setting in Preferences / Interface?

Menturan commented 4 years ago

@Menturan are you using swedish in swedish or a subtype variant, like DVORAK or Macintosh?

No subtype. Standard Swedish layout.