search

BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.07k stars 1.47k forks source link

Nord and Vulcan themes don't work #3554

Closed colineberly closed 4 years ago

colineberly commented 4 years ago

Current behavior

Both Nord and Vulcan are broken on v0.15.3 after update. They both seem to revert to the default theme. I have not checked console logs yet as I don't have the time right now.

Expected behavior

Themes should show their respective colors.

Steps to reproduce

Update to v0.15.3 and choose either theme.

Environment

maximouche commented 4 years ago

With default theme : Screenshot 2020-04-21 at 10 34 10

Code theme is now white text on white bakground.

irimiab commented 4 years ago

It happens only for indented code blocks (those which are under a bullet)

Flexo013 commented 4 years ago

Confirmed on Windows 10 with 0.15.3.

daiyam commented 4 years ago

I've just seen the issue. I will fix it. I won't let my babies be broken... :blush:

Flexo013 commented 4 years ago

This is solved as of Boostnote Legacy version 0.16.0.

Thanks for your contribution @daiyam ❤️

vnmabus commented 3 years ago

The "white text on white background" error is still happening for me in non-dark themes for indented code blocks in version 0.16.1.

Flexo013 commented 3 years ago

@vnmabus Could you give a screenshot example?

I have tested this on 0.16.1 with both Nord and a non-dark theme in combination with light code blocks. I am unable to reproduce the issue.
image

vnmabus commented 3 years ago

Yes of course. This is in 0.16.1 with the default theme:

imagen

Flexo013 commented 3 years ago

That's really odd.

This is what I get when using the default interface theme, with default styled code blocks. Could you check that both those settings are set to default? (Make sure that you don't confuse it with editor style.

image

We could try backing up your notes, then uninstalling entirely and reinstalling, because some theme file might be corrupt on your end.

daiyam commented 3 years ago

@vnmabus Can you specify the Interface Theme, the Preview's Code Block Theme and Preview's Custom CSS you are using, with a markdown example? I can't reproduce your issue.

maximouche commented 3 years ago

It occurs when there is a code block embedded in a bullet/numbered list

lalala 
bimbamboom
- bullet1
  hello
  ```
  some very smart code here
  ```
- bullet2

Here is the result : Screenshot 2020-12-14 at 14 41 27

Here a screenshot a the theme I use Screenshot 2020-12-14 at 14 38 06

vnmabus commented 3 years ago

Yes, at first I though it was only in Windows, but I tried installing the 0.16.1 version in Linux in a different PC (that previously had 0.14 and worked fine) and the same problem occurs.

maximouche commented 3 years ago

it's also present on 0.16.1 on OSX

daiyam commented 3 years ago

+1

daiyam commented 3 years ago

The issue is due to hard coded styles introduced by #3473 before I move them to browser/main/lib/dataApi/formatHTML.js. I did remember wondering why it's there...

vnmabus commented 3 years ago

@vnmabus Can you specify the Interface Theme, the Preview's Code Block Theme and Preview's Custom CSS you are using, with a markdown example? I can't reproduce your issue.

The preview code block theme is "dracula" (I never changed it, maybe it was the default in previous versions?).