BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.07k stars 1.47k forks source link

Fix/update #3577

Closed gregueiras closed 3 years ago

gregueiras commented 4 years ago

Description

boostnote

Fixed the About panel in preferences, as it was not storing the correct values in the preferences manager.

When a new update request is triggered, either by the auto-update or from clicking the update option in the menu, a dialog is shown where the user can disable auto-updates or download the new version. After the download is finished, the user can apply the update and restart or postpone it.

Issue fixed

Fixes #2827

Type of changes

Checklist:

ZeroX-DG commented 4 years ago

Looks good but....I don't think forcing people click save button to save config for auto update check too is a good idea. 2 reasons:

  1. UI: The auto check update is not in the same section with the analytics config so this will confuse user and they will end up not clicking save
  2. UX: The analytics is an important setting since user will have to agree to share their usage. But auto update is not really that important so I think user should be able to enable this simply by check or uncheck the checkbox.

@Rokt33r what do you think?

gregueiras commented 4 years ago

I think both of those reasons make sense, I'll update it

gregueiras commented 4 years ago

Hey @Rokt33r,

can you please take a look at this?

Thanks!

gregueiras commented 3 years ago

Hi @ZeroX-DG hope you are doing well! Can you please ping @Rokt33r so he can review this PR? Thanks! 😄