avoid conflicting styles between inline codes and code blocks - Githubissues

BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App

Other

17.08k stars 1.47k forks source link

avoid conflicting styles between inline codes and code blocks #3675

Closed daiyam closed 3 years ago

daiyam commented 3 years ago

Description

This change avoids conflicting styles between inline codes and code blocks.

Before

before

After

after

Here a short list of conflicting themes:

Interface Theme	Preview Code Block Theme
Default	dracula, monokai
Dark	default

Issue fixed

3554

Type of changes

:radio_button: Bug fix (Change that fixed an issue)
:white_circle: Breaking change (Change that can cause existing functionality to change)
:white_circle: Improvement (Change that improves the code. Maybe performance or development improvement)
:white_circle: Feature (Change that adds new functionality)
:white_circle: Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

:radio_button: My code follows the project code style
:white_circle: I have written test for my code and it has been tested
:radio_button: All existing tests have been passed
:radio_button: I have attached a screenshot/video to visualize my change if possible
:white_circle: This PR will modify the UI or affects the UX
:white_circle: This PR will add/update/delete a keybinding