Regular Expression DoS vulnerability

[yinxiL]

We are working on the ReDoS problem and detected 3 vulnerable regex(es) from your repository.

1: ^[\t]*([\w+#-]+)?(?:\(((?:\s*\w[-\w]*(?:=(?:'(?:.*?[^\\])?'|"(?:.*?[^\\])?"|(?:[^'"][^\s]*)))?)*)\))?(?::([^:]*)(?::(\d+))?)?\s*$ in Boostnote/browser/lib/markdown-it-fence.js 2: ^(?:(?:(?:https?|ftp):)?\/\/)(?:\S+(?::\S*)?@)?(?:(?!(?:10|127)(?:\.\d{1,3}){3})(?!(?:169\.254|192\.168)(?:\.\d{1,3}){2})(?!172\.(?:1[6-9]|2\d|3[0-1])(?:\.\d{1,3}){2})(?:[1-9]\d?|1\d\d|2[01]\d|22[0-3])(?:\.(?:1?\d{1,2}|2[0-4]\d|25[0-5])){2}(?:\.(?:[1-9]\d?|1\d\d|2[0-4]\d|25[0-4]))|(?:(?:[a-z\u00a1-\uffff0-9]-*)*[a-z\u00a1-\uffff0-9]+)(?:\.(?:[a-z\u00a1-\uffff0-9]-*)*[a-z\u00a1-\uffff0-9]+)*(?:\.(?:[a-z\u00a1-\uffff]{2,})).?)(?::\d{2,5})?(?:[/?#]\S*)?$ in Boostnote/browser/main/lib/dataApi/createNoteFromUrl.js 3: ^(~~~+|```+)[ \t]*([\w+#-]+)?(?:\(((?:\s*\w[-\w]*(?:=(?:'(?:.*?[^\\])?'|"(?:.*?[^\\])?"|(?:[^'"][^\s]*)))?)*)\))?(?::([^:]*)(?::(\d+))?)?\s*$ in Boostnote/extra_scripts/codemirror/mode/bfm/bfm.js

Please try the following:

var pattern = "^[\\t]*([\\w+#-]+)?(?:\\(((?:\\s*\\w[-\\w]*(?:=(?:'(?:.*?[^\\\\])?'|\"(?:.*?[^\\\\])?\"|(?:[^'\"][^\\s]*)))?)*)\\))?(?::([^:]*)(?::(\\d+))?)?\\s*$";
var input = "(0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000\b";
var re = new RegExp(pattern);
var matched = input.match(re);

var pattern = "^(?:(?:(?:https?|ftp):)?\\/\\/)(?:\\S+(?::\\S*)?@)?(?:(?!(?:10|127)(?:\\.\\d{1,3}){3})(?!(?:169\\.254|192\\.168)(?:\\.\\d{1,3}){2})(?!172\\.(?:1[6-9]|2\\d|3[0-1])(?:\\.\\d{1,3}){2})(?:[1-9]\\d?|1\\d\\d|2[01]\\d|22[0-3])(?:\\.(?:1?\\d{1,2}|2[0-4]\\d|25[0-5])){2}(?:\\.(?:[1-9]\\d?|1\\d\\d|2[0-4]\\d|25[0-4]))|(?:(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)(?:\\.(?:[a-z\\u00a1-\\uffff0-9]-*)*[a-z\\u00a1-\\uffff0-9]+)*(?:\\.(?:[a-z\\u00a1-\\uffff]{2,})).?)(?::\\d{2,5})?(?:[/?#]\\S*)?$";
var input = "//0.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00\b";
var re = new RegExp(pattern);
var matched = input.match(re);

var pattern = "^(~~~+|```+)[\\t]*([\\w+#-]+)?(?:\\(((?:\\s*\\w[-\\w]*(?:=(?:'(?:.*?[^\\\\])?'|\"(?:.*?[^\\\\])?\"|(?:[^'\"][^\\s]*)))?)*)\\))?(?::([^:]*)(?::(\\d+))?)?\\s*$";
var input = "~~~(00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000\b";
var re = new RegExp(pattern);
var matched = input.match(re);

We didn’t create a pull request because we're not sure if these cases are possible to take place in your program, we also do not understand the functionality of these regexes as you do. Thank you for your understanding.