search

BoostIO / BoostNote-Legacy

This repository is outdated and new Boost Note app is available! We've launched a new Boost Note app which supports real-time collaborative writing. https://github.com/BoostIO/BoostNote-App
Other
17.07k stars 1.47k forks source link

Colors unreadable in Dark Theme after Upgrade to 0.8.8 #478

Closed huettenhain closed 7 years ago

huettenhain commented 7 years ago

After the recent upgrade to 0.8.8, on Windows 10 (and Windows 2k8R2), most of the dark editor themes have severe contrast problems, as I hope you can see from the following sceenshots:

base16-dark: base16-dark

ambiance: ambiance

icecoder: icecoder

isotype: isotype

lesser-dark: lesser-dark

There are some themes that work okay, I am currently using twilight. Still, all of the above themes and also some others are practically unusable because some of the code highlighting simply becomes unreadable.

kazup01 commented 7 years ago

Thank you for trying new design! hmm, my computer(windows 10) is not occur this problem.

sota1235 commented 7 years ago

Can you give me the text? (I guess it is like below)

Simply type `test` or `test -help mode:7`
huettenhain commented 7 years ago

@sota1235: Yea, that's the text. But quite generally, there are some visibility issues in the editor. Not the viewer mind you, only the editor. I don't know where I mentioned this the first time, but I still believe making this fully customizable would be the best idea, i.e. give the users an option to overwrite the default CSS for the design themselves.

kazup01 commented 7 years ago

Sorry for inconvenience. I think I should improve windows UI. Have you already tried to change the font size, font family, editor/code block theme from setting? We can not make fully customizable theme soon because it is low priority, but you can customize it because Boostnote is Open source software.

huettenhain commented 7 years ago

Oh you're brilliant - it was my fault. Apologies! Your UI is great.

I had changed the font and font size several versions ago and for some reason, it was always rendered fine until the recent upgrade. A few tiny adjustments to the font and the font size fixed it.

kazup01 commented 7 years ago

Wow that's great! Enjoy👍